Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: Add tradfriButton cluster #813

Closed
wants to merge 1 commit into from
Closed

Revert "feat: Add tradfriButton cluster #813

wants to merge 1 commit into from

Conversation

lorenzspenger
Copy link

This reverts commit 6e454d8.

the new clusters broke the dots on symfonisk remote.
Another implementation proposed here: Koenkk/zigbee-herdsman-converters#6574

Alternatively we need one more event commandAction6 and a rework of the symfonisk implementation

@Koenkk
Copy link
Owner

Koenkk commented Dec 2, 2023

I think it's better to update the symfonisk integration, could you make a PR for this?

@Koenkk Koenkk mentioned this pull request Dec 2, 2023
Closed
@lorenzspenger
Copy link
Author

I see two options:

  • Add double click to the tradfriButton cluster
  • create new integration for symfonisk and somrig based on the new cluster
  • revert the commit
  • keep using symfonisk integration
  • reuse symfonisk integration for somrig

I think option 2 would mitigate risk and is less work.

I won't have the time to change both integrations at least for this week.

@Koenkk
Copy link
Owner

Koenkk commented Dec 4, 2023

I will fix this in Koenkk/zigbee2mqtt#20003

@Koenkk Koenkk closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzspenger @Koenkk